Few miscellaneous tests #18641

kshyatt · 2016-09-22T22:09:44Z

No description provided.

tkelman · 2016-09-23T05:41:46Z

test/intfuncs.jl

@@ -124,10 +125,14 @@ end
 @test count_zeros(Int64(1)) == 63

 @test factorial(3) == 6
+@test factorial(Int8(3)) == 6


also test the return type with === and (if needed) a conversion on the rhs?

same below for isqrt

(cherry picked from commit 43a6ac1) ref #18641 Test integer fallbacks (cherry picked from commit 70c5e24) Add test for missing rationalize error (cherry picked from commit e6635fa) Added type-checking for intfuncs tests (cherry picked from commit 30fbd88)

kshyatt added 2 commits September 22, 2016 15:08

Test error-throw for reinterpret

43a6ac1

Test integer fallbacks

70c5e24

kshyatt added the test This change adds or pertains to unit tests label Sep 22, 2016

tkelman reviewed Sep 23, 2016

View reviewed changes

tkelman added the backport pending 0.5 label Sep 23, 2016

kshyatt added 2 commits September 23, 2016 10:21

Add test for missing rationalize error

e6635fa

Added type-checking for intfuncs tests

30fbd88

tkelman merged commit 83bcc9d into master Sep 24, 2016

tkelman deleted the ksh/misctest branch September 24, 2016 12:27

tkelman removed the backport pending 0.5 label Mar 5, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Few miscellaneous tests #18641

Few miscellaneous tests #18641

kshyatt commented Sep 22, 2016

tkelman Sep 23, 2016 •

edited

Loading

Few miscellaneous tests #18641

Few miscellaneous tests #18641

Conversation

kshyatt commented Sep 22, 2016

tkelman Sep 23, 2016 • edited Loading

Choose a reason for hiding this comment

tkelman Sep 23, 2016 •

edited

Loading