-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual Conversion #18588
Manual Conversion #18588
Changes from all commits
a1e14c4
20336ae
becd19d
8d47ac8
7f510ec
ef6648c
92fb84c
53811ff
505cdd9
100fb02
002bd73
74e7764
d88c3c5
04fc039
b4f4525
5e17741
1da93f3
a43c921
fa04dc4
ed4ab64
f2107d3
e0de340
d47b40e
e32b45f
454ace8
679e136
f86ab7a
fba60de
ff846a8
0d65411
0b6f736
1f1f668
0163ce8
f0abd07
a41cc4a
36d07ae
e94288a
46f1efa
de3f705
2341ca3
cbb6124
a40eb3b
177bdbf
3ab2174
6c44fbe
3276c6a
2e88791
63c89cf
eb940fa
b21cd89
c4c515b
c3cb729
ba1a672
e478fe0
a48c67c
aa6078c
2e9d4f8
ac38d3a
2b40b77
c878340
4dae035
017a9f7
ae1de4d
b43dff4
c244c0e
da67cb6
134ac3a
2abbdfa
94de094
435d925
0341030
1df1d1e
ae6d027
aebc200
b69a5fd
d8f5b4e
cc40c6a
0d74803
b0fb710
5e9a2c4
c659571
33be9c3
1e39955
eb722cb
226e12a
c4ea3a0
bb62572
5cff3ab
08338b7
105624a
1c58e98
bd35156
b1d015a
abddf00
421633d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,10 +105,7 @@ julia-debug julia-release : julia-% : julia-ui-% julia-sysimg-% julia-symlink ju | |
|
||
debug release : % : julia-% | ||
|
||
julia-genstdlib: julia-sysimg-$(JULIA_BUILD_MODE) | ||
@$(call PRINT_JULIA, $(JULIA_EXECUTABLE) $(call cygpath_w, $(JULIAHOME)/doc/genstdlib.jl)) | ||
|
||
docs: julia-genstdlib | ||
docs: julia-sysimg-$(JULIA_BUILD_MODE) | ||
@$(MAKE) $(QUIET_MAKE) -C $(BUILDROOT)/doc | ||
|
||
check-whitespace: | ||
|
@@ -120,21 +117,11 @@ endif | |
|
||
release-candidate: release testall | ||
@$(JULIA_EXECUTABLE) $(JULIAHOME)/contrib/add_license_to_files.jl #add license headers | ||
@$(JULIA_EXECUTABLE) $(JULIAHOME)/doc/genstdlib.jl | ||
@#Check documentation | ||
@$(JULIA_EXECUTABLE) $(JULIAHOME)/doc/NEWS-update.jl #Add missing cross-references to NEWS.md | ||
@$(MAKE) -C $(BUILDROOT)/doc unicode #Rebuild Unicode table if necessary | ||
@$(JULIA_EXECUTABLE) $(JULIAHOME)/doc/DocCheck.jl > $(BUILDROOT)/doc/UNDOCUMENTED.rst 2>&1 #Check for undocumented items | ||
@if [ -z "$(cat $(BUILDROOT)/doc/UNDOCUMENTED.rst)" ]; then \ | ||
rm $(BUILDROOT)/doc/UNDOCUMENTED.rst; \ | ||
else \ | ||
echo "Undocumented functions found in doc/UNDOCUMENTED.rst; document them, then retry"; \ | ||
exit 1; \ | ||
fi | ||
@$(MAKE) -C $(BUILDROOT)/doc html SPHINXOPTS="-n" #Rebuild Julia HTML docs pedantically | ||
@$(MAKE) -C $(BUILDROOT)/doc latex SPHINXOPTS="-n" #Rebuild Julia PDF docs pedantically | ||
@$(MAKE) -C $(BUILDROOT)/doc doctest #Run Julia doctests | ||
@$(MAKE) -C $(BUILDROOT)/doc linkcheck #Check all links | ||
@$(MAKE) -C $(BUILDROOT)/doc html | ||
@$(MAKE) -C $(BUILDROOT)/doc pdf | ||
@$(MAKE) -C $(BUILDROOT)/doc check | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should use strict mode here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
@# Check to see if the above make invocations changed anything important | ||
@if [ -n "$$(git status --porcelain)" ]; then \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we port this or is this totally bitrotted and useless right now? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Documenter provides pretty much the same features for checking for missing docs. Should be fine to remove. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this never actually did anything since it's just defining a module but not running any of the code it defines |
||
|
@@ -329,8 +316,9 @@ define stringreplace | |
$(build_depsbindir)/stringreplace $$(strings -t x - $1 | grep '$2' | awk '{print $$1;}') '$3' 255 "$(call cygpath_w,$1)" | ||
endef | ||
|
||
install: $(build_depsbindir)/stringreplace $(BUILDROOT)/doc/_build/html | ||
install: $(build_depsbindir)/stringreplace | ||
@$(MAKE) $(QUIET_MAKE) all | ||
@$(MAKE) $(QUIET_MAKE) docs | ||
@for subdir in $(bindir) $(libexecdir) $(datarootdir)/julia/site/$(VERSDIR) $(docdir) $(man1dir) $(includedir)/julia $(libdir) $(private_libdir) $(sysconfdir); do \ | ||
mkdir -p $(DESTDIR)$$subdir; \ | ||
done | ||
|
@@ -379,7 +367,6 @@ endif | |
# Copy documentation | ||
cp -R -L $(build_docdir)/* $(DESTDIR)$(docdir)/ | ||
cp -R -L $(BUILDROOT)/doc/_build/html $(DESTDIR)$(docdir)/ | ||
-rm $(DESTDIR)$(docdir)/html/.buildinfo | ||
# Remove perf suite | ||
-rm -rf $(DESTDIR)$(datarootdir)/julia/test/perf/ | ||
# Remove various files which should not be installed | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,7 +29,7 @@ end | |
""" | ||
@enum EnumName EnumValue1[=x] EnumValue2[=y] | ||
Create an [`Enum`](:obj:`Enum`) type with name `EnumName` and enum member values of | ||
Create an `Enum` type with name `EnumName` and enum member values of | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is there going to be autodetection of some kind for references like these? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Re: autodetection, I think we can probably add, at some point, a check to Documenter that will suggest non-references that could be references. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah. Was this the case for all of the ones you removed in this commit? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, there's a whole bunch that aren't links any more: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And none of those types have docstrings? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly for UInt, Int, Float16 types. I think seems like this could be fixed in a later PR. Linking every There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Those ones as well. What I'll do is put together a list of which ones are missing after this conversion is done and open an up-for-grabs issue to track which ones still need documenting. |
||
`EnumValue1` and `EnumValue2` with optional assigned values of `x` and `y`, respectively. | ||
`EnumName` can be used just like other types and enum member values as regular values, such as | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be emphasized that the nothing in the
_build
directory is supposed to be commited?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, can do.
_build
is in the.gitignore
so it's probably not really necessary, but probably worth mentioning anyway.