-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release 0.4] cache compile dep tracking #18230
[release 0.4] cache compile dep tracking #18230
Conversation
18304e7
to
e7ed9a5
Compare
please use |
Bump. Can we get this merged? |
If @vtjnash doesn't do so, then I'll redo this with cross-references if needed when preparing 0.4.7. |
It would be nice to get this on the release-0.4 branch soon, so that we can get a nightly and test whether that would fix the issue we have been seeing on juliabox. Cc @nkottary |
Classes are starting soon, and we'd like to address this asap before lots of people get onto juliabox. |
We only build nightlies from master. I can trigger a custom build from this branch for testing purposes, but it doesn't happen automatically. |
Good to know, and certainly valuable in this case. Can you trigger a build for this branch? That would help us test, while the PR gets ready for eventual merging and release. |
e7ed9a5
to
917acce
Compare
travis failure was a build Makefile race condition, unrelated to the PR. @tkelman I assume you'll merge this when you want it for the next nightly / release-0.4 build |
This seemed to be more stable on juliabox than the current release. @nkottary Can you chime in? |
Yes, this build does not emit the precompilation warnings and errors that we were seeing in the release on JuliaBox. |
I haven't run pkgeval here yet, but I suspect this will have the same issues we're seeing on release-0.5. |
This only has part of the PR that is on 0.5. Hence, there is some chance it doesn't have the same issues. Good to know though. |
backport #18150