Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release 0.4] cache compile dep tracking #18230

Merged
merged 2 commits into from
Sep 13, 2016

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Aug 24, 2016

backport #18150

@vtjnash vtjnash force-pushed the jn/release-0.4-cache-compile-dep-tracking branch from 18304e7 to e7ed9a5 Compare August 24, 2016 21:19
@tkelman
Copy link
Contributor

tkelman commented Aug 24, 2016

please use cherry-pick -x -e and add the reference to the PR number to the commit messages so everything is cross-referenced.

@ViralBShah
Copy link
Member

Bump. Can we get this merged?

@tkelman
Copy link
Contributor

tkelman commented Aug 29, 2016

If @vtjnash doesn't do so, then I'll redo this with cross-references if needed when preparing 0.4.7.

@ViralBShah
Copy link
Member

It would be nice to get this on the release-0.4 branch soon, so that we can get a nightly and test whether that would fix the issue we have been seeing on juliabox.

Cc @nkottary

@ViralBShah
Copy link
Member

Classes are starting soon, and we'd like to address this asap before lots of people get onto juliabox.

@tkelman
Copy link
Contributor

tkelman commented Aug 29, 2016

We only build nightlies from master. I can trigger a custom build from this branch for testing purposes, but it doesn't happen automatically.

@ViralBShah
Copy link
Member

Good to know, and certainly valuable in this case. Can you trigger a build for this branch? That would help us test, while the PR gets ready for eventual merging and release.

@tkelman
Copy link
Contributor

tkelman commented Aug 29, 2016

@vtjnash vtjnash force-pushed the jn/release-0.4-cache-compile-dep-tracking branch from e7ed9a5 to 917acce Compare August 30, 2016 19:07
@vtjnash
Copy link
Member Author

vtjnash commented Sep 5, 2016

travis failure was a build Makefile race condition, unrelated to the PR. @tkelman I assume you'll merge this when you want it for the next nightly / release-0.4 build

@ViralBShah
Copy link
Member

This seemed to be more stable on juliabox than the current release. @nkottary Can you chime in?

@nkottary
Copy link
Contributor

nkottary commented Sep 5, 2016

Yes, this build does not emit the precompilation warnings and errors that we were seeing in the release on JuliaBox.

@tkelman
Copy link
Contributor

tkelman commented Sep 5, 2016

I haven't run pkgeval here yet, but I suspect this will have the same issues we're seeing on release-0.5.

@ViralBShah
Copy link
Member

This only has part of the PR that is on 0.5. Hence, there is some chance it doesn't have the same issues. Good to know though.

@ViralBShah ViralBShah added this to the 0.4.x milestone Sep 10, 2016
@tkelman tkelman merged commit 3b06c86 into release-0.4 Sep 13, 2016
@tkelman tkelman deleted the jn/release-0.4-cache-compile-dep-tracking branch September 13, 2016 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants