Misc build fixes for win32 clang #18164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's a problem if you're using msvcrt. what does clang default to for the stack alignment? |
|
I can't imagine it defaults to anything that doesn't work with msvcrt, since it's designed primary as a microsoft-compatible compiler. |
| CXX_BASE := $(shell echo $(CXX) | cut -d' ' -f1) | ||
| CXX_ARG := $(shell echo $(CXX) | cut -d' ' -f2-) |
There was a problem hiding this comment.
do these get used anywhere?
There was a problem hiding this comment.
It's used in deps for passing arguments to CMake.
This was referenced Aug 22, 2016
tkelman
added a commit
that referenced
this pull request
Aug 23, 2016
of cmake projects with gcc - CC_ARG and CXX_ARG are getting double processed somewhere, so cmake is trying to call the compiler as '/usr/bin/gcc gcc'
tkelman
added a commit
that referenced
this pull request
Aug 23, 2016
of cmake projects with gcc - CC_ARG and CXX_ARG are getting double processed somewhere, so cmake is trying to call the compiler as '/usr/bin/gcc gcc' add cut -s
tkelman
added a commit
that referenced
this pull request
Aug 23, 2016
of cmake projects with gcc - CC_ARG and CXX_ARG are getting double processed somewhere, so cmake is trying to call the compiler as '/usr/bin/gcc gcc' add cut -s
Keno
added a commit
that referenced
this pull request
Aug 23, 2016
Revert the part of #18164 that broke the build
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
of cmake projects with gcc - CC_ARG and CXX_ARG are getting double processed somewhere, so cmake is trying to call the compiler as '/usr/bin/gcc gcc' add cut -s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang doesn't support
mincoming-stack-boundary. I would assume that's ok as long as everything is built with clang. If it comes up as a problem I'll look for a way to achieve the same result.