improve FreeBSD / generic posix support #18063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vtjnash
commented
Aug 16, 2016
•
vtjnash
commented
- add libuv patch
|
|
||
| $ gmake FC=gfortran47 | ||
| $ echo 'FC=gfortran6` >> Make.user |
[ci skip]
vtjnash
changed the title
|
@tkelman I'll leave it up to you whether you want to backport this now, or wait to see if FreeBSD users submit more patches |
| @@ -84,12 +84,24 @@ static void jl_call_in_ctx(jl_ptls_t ptls, void (*fptr)(void), void *_ctx) | |||
| *(void**)rsp = NULL; | |||
| ctx->uc_mcontext.gregs[REG_RSP] = rsp; | |||
| ctx->uc_mcontext.gregs[REG_RIP] = (uintptr_t)fptr; | |||
| #elif defined(_OS_FREEBSD_) && defined(_CPU_X86_64_) | |||
There was a problem hiding this comment.
This change and the other 2 sections in jl_call_in_ctx do not backport cleanly to release-0.5 since #17727 was not backported. Okay to just not change jl_call_in_ctx at all there?
There was a problem hiding this comment.
If this code doesn't exist here, there shouldn't be anything to fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.