Better documentation for performance annotations #17700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
docs
lopezm94
changed the title
| Both :obj:`@simd` and :obj:`@inbounds` do a simple rewrite of the expression | ||
| and delegate the optimizations to compiler, much like ``:meta`` expressions. | ||
| This means they merely give the compiler license to optimize. Whether | ||
| it actually does so depends on the compiler. As consequence how you |
There was a problem hiding this comment.
"As consequence" is not grammatical. Actually, I think you can just delete the "As consequence..." sentence.
|
Thank you for the much needed corrections |
|
I think is ready for merging |
| @@ -932,6 +927,13 @@ On a computer with a 2.4GHz Intel Core i5 processor, this produces:: | |||
| GFlop = 1.9467069505224963 | |||
| GFlop (SIMD) = 17.578554163920018 | |||
|
|
|||
| Certain preconditions need to be met before using some of these macros. | |||
| Both :obj:`@simd` and :obj:`@inbounds` do a simple rewrite of the expression | |||
| and delegate the optimizations to compiler, much like ``:meta`` expressions. | |||
There was a problem hiding this comment.
delegate the optimizations to the compiler
|
Please reopen this against master. |
|
Note, for future reference, that it is better to do a forced push to an existing PR than to open a new PR. |
|
Not when the target branch is wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That sentence might make you think applying it to a function will remove bounds check.
which is not true as seen here