Fix #17462, break/continue in an at-testset for loop #17692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make the macro return a :for instead of a :comprehension
Add some counters to make sure things actually execute
|
I might not be understanding how testsets are supposed to work, but one strange thing here is that if I put a failing test inside the testset then I get a backtrace but |
|
@tkelman That is a bug that my big ball of testset mud PR fixes |
|
could it be split out so it would be an 0.5 backport candidate? |
|
It might be kind of hard to |
|
if it's a bugfix that's doable independently of the rest of that pr that would be best. though there isn't quite a release-0.5 branch just yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes NearestNeighbors.jl.