Libgit2 usability issues #17586
Merged
Libgit2 usability issues #17586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,6 +59,8 @@ function credentials_callback(cred::Ptr{Ptr{Void}}, url_ptr::Cstring, | |||
| # parse url for schema and host | |||
| urlparts = match(urlmatcher, url) | |||
| schema = urlparts.captures[1] | |||
| urlusername = urlparts.captures[4] | |||
| urlusername == nothing && (urlusername = "") | |||
Closed
| @@ -59,6 +59,8 @@ function credentials_callback(cred::Ptr{Ptr{Void}}, url_ptr::Cstring, | |||
| # parse url for schema and host | |||
| urlparts = match(urlmatcher, url) | |||
| schema = urlparts.captures[1] | |||
| urlusername = urlparts.captures[4] | |||
There was a problem hiding this comment.
usually, username from url is git for git+ssh protocol. You can use username_ptr parameter to get it.
There was a problem hiding this comment.
Sorry, not sure what you're suggesting. The urlusername only ever gets used by https. Are you saying that libgit2 is already extracting this, so we should just load it from username_ptr?
There was a problem hiding this comment.
ok, for https username_ptr is NULL
Keno
force-pushed
the
kf/libgit2usability
branch
from
8eb5ce2 to
ff75ca4
Compare
Keno
force-pushed
the
kf/libgit2usability
branch
from
ff75ca4 to
c652593
Compare
|
I've rebased out the test and will open that as a separate pull request. |
| @@ -114,15 +116,23 @@ function credentials_callback(cred::Ptr{Ptr{Void}}, url_ptr::Cstring, | |||
| ENV["SSH_KEY_PATH"] | |||
| else | |||
| keydefpath = creds[:prvkey, credid] # check if credentials were already used | |||
| if keydefpath !== nothing && !isusedcreds | |||
| keydefpath == nothing && (keydefpath = "") | |||
Keno
force-pushed
the
kf/libgit2usability
branch
2 times, most recently
from
2b7f6ca to
b4b2b4c
Compare
Encrypted keys have `Proc-Type: 4,ENCRYPTED`, so check for that before requiring a passkey. Part of #17541.
Only prompt for a different private key. If authentication with the first key fails. This can be a little annoying if one wants to use a different private key, but the default one is encrypted, so it queries for a password, without asking for the key first. However, in that case, one probably wants to use the environment variables or the ssh agent anyway, so I'm not too concerned.
Keno
force-pushed
the
kf/libgit2usability
branch
from
b4b2b4c to
7ba3ebd
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP, because the test fails non-deterministically and I've been unable to debug (was trying to use rr to figure out what's happening, but it crashes rr). Just putting this up so people can see what part of #17541 is already done. Will get back to fixing the test a little later.