Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make libssh stack more robust to rebuilds #17475

Merged
merged 3 commits into from
Jul 18, 2016
Merged

Make libssh stack more robust to rebuilds #17475

merged 3 commits into from
Jul 18, 2016

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Jul 18, 2016

see commit messages, this should allow us to revert 854d905 and hopefully get the buildbots working more reliably since the merge of #17391

(we might want to generalize the LLVM_PATCH macro and use it everywhere at some point)

tkelman added 2 commits July 18, 2016 02:58
see https://cmake.org/Bug/view.php?id=14366, the cache was getting
deleted because it thought CMAKE_C_COMPILER was changing, causing
issues with missing destdir paths when doing the install
with libgit2, libssh2, and mbedtls - the dependencies are
order-only '|' on CMakeLists.txt since applying the patches
changes that file
@tkelman tkelman added the building Build system, or building Julia or its dependencies label Jul 18, 2016
@tkelman
Copy link
Contributor Author

tkelman commented Jul 18, 2016

i686-linux travis froze, log backed up to https://gist.github.com/0573e8ca6e7bf0e0bd7f5c138d77cb4a and restarted

@tkelman
Copy link
Contributor Author

tkelman commented Jul 18, 2016

cc @Keno @vtjnash for review

@Keno
Copy link
Member

Keno commented Jul 18, 2016

LGTM.

@vtjnash vtjnash merged commit e2269dc into master Jul 18, 2016
@vtjnash vtjnash deleted the tk/sshbuild branch July 18, 2016 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants