fix #17338, broken showing of SimpleVector #17339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -173,6 +173,7 @@ done(v::SimpleVector,i) = (i > v.length) | |||
| isempty(v::SimpleVector) = (v.length == 0) | |||
| indices(v::SimpleVector) = (OneTo(length(v)),) | |||
| linearindices(v::SimpleVector) = indices(v, 1) | |||
| indices(v::SimpleVector, d) = d <= 1 ? indices(v)[d] : OneTo(1) | |||
There was a problem hiding this comment.
this isn't the default fallback definition for indices ?
There was a problem hiding this comment.
Yes, but SimpleVector is not an AbstractArray. It might be possible to make it so, but that would be a more complicated change.
There was a problem hiding this comment.
does the fallback need to be only for AbstractArray or does it make sense for Any?
There was a problem hiding this comment.
Seems reasonable to make it the default fallback. EDIT: nvm, ndims isn't defined for SimpleVector and in any case isn't inferrable, so that would lead to performance regressions in some cases.
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.