RFC: Remove command-line Git from Mac and Windows binaries #17294
Conversation
|
I expect to finish up the rest of the test modifications here tonight, just so people are aware. |
|
I think that @vtjnash was working on adding BusyBox back. Not sure how that went. |
|
It's not like we need to build it from source which might get a bit complicated, I was just planning on downloading a binary in win-extras since we'll only be using it for test purposes for the time being. We could leverage it for more interesting things later if we want to, edit: actually I think we're probably fine re: GPL because we're only invoking it as a command-line program and not linking to it, probably falls under the aggregation clause |
We may want to make this conditional on USE_GPL_LIBS, though since we're only running it as a command line executable and not linking to it, it probably falls under the aggregation clause
note that one test involving perl is being skipped, but it had been disabled until recently - ref e412c69
tkelman
force-pushed
the
tk/killgitwithfire
branch
from
9647f1e to
b847d10
Compare
tkelman
changed the title
| # - GNU coreutils (or equivalent) | ||
| # - perl | ||
|
|
||
| #TODO: |
There was a problem hiding this comment.
yay addressing 4-year-old TODO's 1ddd163
it usually won't be in source builds
|
osx travis failure was a libgit2 segfault probably caused by #16537 |
This is step 4 to fix #13958 (comment)
Git.jl is mostly set up at https://github.com/JuliaPackaging/Git.jl (thanks @ararslan for your help cleaning it up), though still need to
Then
Some of base Julia's tests assume coreutils (and perl) are present, and on Windows we've been borrowing those from the bundled Git.
when GPL is allowed, skip the tests in a no-GPL build if coreutils isn't found. Or powershell-ify the tests.