some generally-applicable changes from #16622 #17214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1269,7 +1269,6 @@ function tmerge(typea::ANY, typeb::ANY) | |||
| if isa(typea, DataType) && isa(typeb, DataType) && length(typea.parameters) == length(typeb.parameters) && !isvatuple(typea) && !isvatuple(typeb) | |||
| return typejoin(typea, typeb) | |||
| end | |||
| return Tuple | |||
There was a problem hiding this comment.
did something change such that the fix for #6704 isn't useful anymore? Tuples must widen really fast or inference can get stuck trying to infer some really bad cases. (IIUC, you are finding that the lack of a recursive version of this test causes #14743 (comment))
There was a problem hiding this comment.
Not sure. We need to do something here, so that it's possible to infer the result of (tup::Union{Tuple{Bool}, Tuple{Bool,Int}})[1]. Maybe allow a max of only 2 tuple types in a union?
There was a problem hiding this comment.
Ok I found a good more conservative version of this that doesn't affect performance on #6704.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.