Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calculate ismonday with 100% less eval #17052

Merged
merged 1 commit into from
Jun 21, 2016
Merged

calculate ismonday with 100% less eval #17052

merged 1 commit into from
Jun 21, 2016

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jun 21, 2016 •
edited
Loading

@quinnj
Copy link
Member

quinnj commented Jun 21, 2016

Oh yeah, I think you mentioned changing this like a year or two ago :bowtie:

@tkelman
Copy link
Contributor

tkelman commented Jun 21, 2016 •
edited
Loading

Does negate really need to be an argument if these already take a function?

@yuyichao
Copy link
Contributor

The type check also seems strange since it doesn't really grantee the function will return Bool later.

@kshyatt kshyatt added the dates Dates, times, and the Dates stdlib module label Jun 21, 2016
@vtjnash vtjnash merged commit 5ed294d into master Jun 21, 2016
@vtjnash vtjnash deleted the jn/dates-noevil branch June 21, 2016 21:43
@JeffBezanson JeffBezanson mentioned this pull request Jun 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dates Dates, times, and the Dates stdlib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vtjnash @quinnj @tkelman @yuyichao @kshyatt