GC clean up #16654
Merged
GC clean up #16654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
force-pushed
the
yyc/gc/cleanup
branch
2 times, most recently
from
4a05f4e to
3fb8728
Compare
|
Travis really don't want to run this PR somehow? |
|
lgtm so far |
yuyichao
force-pushed
the
yyc/gc/cleanup
branch
8 times, most recently
from
4053084 to
b44df31
Compare
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
yuyichao
force-pushed
the
yyc/gc/cleanup
branch
3 times, most recently
from
af3e441 to
a9c0357
Compare
* Remove a few unused variables * Remove unused mark mode * Remove `SWAP_wr`
…o gc-debug.c Also move MEMPROFILE to gc-debug.c (still broken)
* Now that the page metadata is accurate, we don't need to backoff when we sweep an empty page anymore. * Remove `MEMDEBUG` in page sweep since it's not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #16632 to avoid massive merge conflict...
Main changes are,
Delete left over logic from the incremental GC.
We are making a lot of assumptions about the marking bit and the deleted part should be the easiest part to fix if we want the incremental behavior back at some point...
Replace
sweep_maskwithsweep_full.The mask is effectively a bool for the two types of sweep we have.
Move more debugging code into
gc-debug.cThis also remove some unnecessary counter increments for the build without these debug options enabled. (the release build might be able to optimize those out automatically).