Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error on copy of expr with partially undefined Array #16353

Closed
wants to merge 1 commit into from
Closed

Fix error on copy of expr with partially undefined Array #16353

wants to merge 1 commit into from

Conversation

Keno
Copy link
Member

@Keno Keno commented May 13, 2016

@JeffBezanson
Copy link
Member

Actually, I'm not sure we depend on embedding Array{Any}s in ASTs any more. There are only 2 callers of astcopy, and they are in inference for copying the code array of a LambdaInfo. These should just use map(copy, code) instead. In fact if an array is interpolated into an AST, I would say we should definitely not copy it.

@Keno
Copy link
Member Author

Keno commented May 13, 2016

Yes, I'd be fine with that.

@JeffBezanson JeffBezanson mentioned this pull request May 15, 2016
Merged
@tkelman tkelman deleted the kf/exprcopy branch May 16, 2016 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Keno @JeffBezanson