Function names cannot be reserved words #15991
Merged
+20
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| stagedfunction function macro quote let local global const | ||
| abstract typealias type bitstype immutable ccall do | ||
| module baremodule using import export importall)) | ||
|
|
||
| (define initial-reserved-word? (Set initial-reserved-words)) | ||
|
|
||
| (define reserved-words '(begin end while if else for try catch finally return break continue |
There was a problem hiding this comment.
Do we really need to repeat this list here?
There was a problem hiding this comment.
You're right, fixed.
|
Would be good to add a test. |
macros are unchanged, for now (to accomodate @catch)
|
added tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this does not affect macros (to accommodate
@catchin #15409)fixes #15661