WIP: overhaul file name info #15583
Closed
WIP: overhaul file name info #15583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
force-pushed
the
jb/filenames2
branch
from
2115b32 to
abbed86
Compare
JeffBezanson
force-pushed
the
jb/filenames2
branch
from
abbed86 to
c03203d
Compare
- add location info to empty blocks; fixes #15280 - remove file names from non-initial `line` nodes - emit `(meta push_loc filename)` and `(meta pop_loc)` around nested blocks from different files, to handle macros - fix line number of `catch` blocks
JeffBezanson
force-pushed
the
jb/filenames2
branch
from
c03203d to
45111a8
Compare
Closed
|
what's blocking this? |
|
The two unchecked items above. #14949 has some needed changes in how we represent location info in LLVM. Without something similar to those changes it's not as easy to use filename push and pop. |
|
Now part of #16335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for #15000. Designed to go with #14949.
This change removes file names from
linenodes, instead changing the current file name as necessary with metapush_locandpop_locnodes (exact names TBD).File names are still present in
linenodes in surface ASTs, so macros should be unaffected.Todo:
push_locshowtest