Re-enable custom docstring types. #15428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom docstring support was lost in JuliaLang#15266. This remedies the regressions introduced there as well as fixing `Text` and `HTML` display signatures that were also broken, likely when `Function` became an abstract type, and had gone unnoticed. Also adds a test case based on PyPlot to hopefully avoid future regressions. Fixes JuliaLang#15424.
|
@MichaelHatherly, I've just tried PyCall on the latest For now, I think your home-brewed |
|
The PyCall failure is #15300 (comment) |
|
Good, not just me then. Thanks for checking! |
|
Thanks @yuyichao. Looks like PyPlot's docstrings are working fine now with this pr. |
MichaelHatherly
added a commit
that referenced
this pull request
Mar 10, 2016
Re-enable custom docstring types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom docstring support was lost in #15266. This remedies the regressions introduced there as well as fixing
TextandHTMLdisplay signatures that were also broken, likely whenFunctionbecame an abstract type, and had gone unnoticed.
Also adds a test case based on PyPlot to hopefully avoid future regressions.
Fixes #15424.
@stevengj, I've been having trouble loading PyPlot and encountered the following error
during pre-compilation, which doesn't seem to be related to the docsystem issue as far as I can see. Would you be able to confirm locally whether this pr fixes PyPlot? Thanks.