Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grab-bag of inference and codegen related improvements #15261

Merged
merged 5 commits into from
Feb 29, 2016
Merged

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Feb 27, 2016

there's not really a common thread to these commits, just several little fixes and improvements I noticed while testing my jn/typeinfq branch

try
v = f(args...)
v = ccall(:jl_apply_generic, Any, (Ptr{Any}, UInt32), args, length(args))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ccall really necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. just trying to see if it could skip copying the array

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should i change it to v = f(args[2:end]...) or v = _apply(f, args[2:end])?

JeffBezanson added a commit that referenced this pull request Feb 29, 2016
grab-bag of inference and codegen related improvements
@JeffBezanson JeffBezanson merged commit 9cda4ab into master Feb 29, 2016
@vtjnash vtjnash deleted the jn/grabbag branch February 29, 2016 19:52
@tkelman tkelman added the needs tests Unit tests are required for this change label Dec 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs tests Unit tests are required for this change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants