Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move dirname.c from flisp/ to support/ #15031

Merged
merged 1 commit into from
Feb 12, 2016
Merged

move dirname.c from flisp/ to support/ #15031

merged 1 commit into from
Feb 12, 2016

Conversation

JeffBezanson
Copy link
Member

This is a general utility and not specifically part of flisp.

Need to make sure this works on windows and MSVC (to the extent possible).

@tkelman
Copy link
Contributor

tkelman commented Feb 11, 2016

I haven't been maintaining the Windows.mk nmake files, I don't think they work. If we switch to cmake (or add it as an option) we can get rid of them. For now the easiest way to test against msvc is turning appveyor on for your fork and rebasing this branch: https://github.com/tkelman/julia/tree/tk/avmsvc

Note that the msvc llvm binaries are still against llvm 3.3. I don't have msvc on my new system yet, and upstream doesn't believe in including static libraries in their windows binary installer.

@JeffBezanson
Copy link
Member Author

Ok, thanks. I will interpret that as "if this passes normal CI we can merge it" :)

@tkelman
Copy link
Contributor

tkelman commented Feb 12, 2016

No, not quite. "If https://ci.appveyor.com/project/tkelman/julia/build/1.0.737 gets to bootstrap we can merge it." Which it didn't No rule to make target /c/projects/julia/src/support/dirname.c.o', needed by /c/projects/julia/src/support/libsupport.a'. Stop.

@JeffBezanson
move dirname.c from flisp/ to support/
7455a81 
This is a general utility and not specifically part of flisp.
@JeffBezanson
Copy link
Member Author

Ack, ok, I think I see my mistake there.

@tkelman
Copy link
Contributor

tkelman commented Feb 12, 2016

Good call, cuz I didn't. If https://ci.appveyor.com/project/tkelman/julia/build/1.0.738 gets to bootstrap, then ok to merge. edit: 👍

@JeffBezanson
Copy link
Member Author

AV failure is #14991

JeffBezanson added a commit that referenced this pull request Feb 12, 2016
@JeffBezanson
Merge pull request #15031 from JuliaLang/jb/movedirname
fe44be4 
move `dirname.c` from flisp/ to support/
@JeffBezanson JeffBezanson merged commit fe44be4 into master Feb 12, 2016
@tkelman tkelman deleted the jb/movedirname branch February 12, 2016 06:48
tkelman added a commit that referenced this pull request Jun 4, 2016
@tkelman
Add license acknowledgement of mingw for src/support/dirname.c
06f1857 
ref 6d6ad0b, this file used to
be under src/flisp until #15031 so contrib/add_license_to_files.jl
was missing it [av skip]
vchuravy pushed a commit to JuliaPackaging/LazyArtifacts.jl that referenced this pull request Oct 2, 2023
@tkelman
Add license acknowledgement of mingw for src/support/dirname.c
0be5a30 
ref 6d6ad0b07b86a10a13d5d7a1eab90b599988f496, this file used to
be under src/flisp until JuliaLang/julia#15031 so contrib/add_license_to_files.jl
was missing it [av skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffBezanson @tkelman