-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add -fPIC to julia-config.jl #14443
add -fPIC to julia-config.jl #14443
Conversation
Not just |
Should probably update the embedding doc too. |
done |
|
And if |
I'm not really in a position to add these tests, all I know is that without |
Needs to at least be unix only, and maybe more specific to just linux? Just 64 bit linux? Or any 64 bit unix? Depending on where it's required. |
Anyone have an idea if this is needed on OS X also? |
or freebsd for that matter? |
I doubt it's harmful though |
We pass |
On Windows it's a really annoying and prominent warning, so absolutely needs to be taken out there. |
How's this? |
LGTM |
@yuyichao found that
-fPIC
is needed so that the GC stack is properly initialized. I've tested on linux only.