Take Git/usr/bin off the path on Windows #14206
Conversation
to hopefully fix starting the binaries in Cygwin or MSYS2 ref https://groups.google.com/forum/#!msg/julia-users/tCfrhMWBEwk/K4-nde_1BQAJ adjust paths in spawn test so it still passes
to hopefully fix starting the binaries in Cygwin or MSYS2 ref https://groups.google.com/forum/#!msg/julia-users/tCfrhMWBEwk/K4-nde_1BQAJ adjust paths in spawn test so it still passes (cherry picked from commit a019769) ref #14206
|
pkg, git, and all other tests seem to work okay on binaries built from 0.4 with this backported (on master it doesn't matter so much since we're using libgit2). This change will potentially make it more obvious when packages are doing non-portable things like shelling out to coreutils, by taking the embedded git's coreutils (and perl etc) off of Julia's path by default. This is the more future-proof option anyway, and when I work on closing #13958 I'll look into putting busybox-w32 back and adding some shell wrapper code so packages or the spawn test can use that if they want to (at least in GPL-allowed builds of Julia). |
tkelman
force-pushed
the
tk/gitpath
branch
2 times, most recently
from
9337df4 to
07f65c0
Compare
iconv and perl in test/strings/io.jl cat in test/cmdlineargs.jl
|
This fixes the "Inappropriate ioctl for device" error mentioned in #14174, so I'll be merging soon if no comments otherwise. |
Take Git/usr/bin off the path on Windows
to hopefully fix starting the binaries in Cygwin or MSYS2
ref https://groups.google.com/forum/#!msg/julia-users/tCfrhMWBEwk/K4-nde_1BQAJ
adjust paths in spawn test so it still passes