Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid race condition when removing cache file #14145

Merged
merged 1 commit into from
Nov 29, 2015

Conversation

eschnett
Copy link
Contributor

No description provided.

@eschnett
Copy link
Contributor Author

This addresses #14118 .

tkelman added a commit that referenced this pull request Nov 29, 2015
Avoid race condition when removing cache file
@tkelman tkelman merged commit a1af47a into JuliaLang:master Nov 29, 2015
@tkelman
Copy link
Contributor

tkelman commented Nov 29, 2015

I think there's technically a chance that rm could throw something other than a ENOENT, in which case this would mask #12720. This probably calls for either a fancier catch that checks the exception type, or a force keyword argument that ignores nonexistent files.

@eschnett eschnett deleted the eschnett/cache branch December 1, 2015 23:30
@eschnett
Copy link
Contributor Author

eschnett commented Dec 3, 2015

See #14248.

@tkelman
Copy link
Contributor

tkelman commented Dec 3, 2015

Great. I don't think I want to backport this version, unless it gets changed to add more of the checking of exceptions that you're putting into the force kwarg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants