Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.3] backports for 0.3.12 #13718

Merged
merged 8 commits into from
Oct 26, 2015
Merged

[release-0.3] backports for 0.3.12 #13718

merged 8 commits into from
Oct 26, 2015

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Oct 22, 2015

Been a while since 0.3.11, we had a bunch of 0.4.0 release candidates to worry about. Since there are a few commits already on release-0.3 that haven't been released, and a few more tagged for "backport pending 0.3," figured we should probably do one last tag. I'll build test binaries from this branch and run PkgEval to compare with 0.3.11, make sure there are no regressions at least in automatically tested code. If anyone identifies any regression between 0.3.x and 0.3.12 at any point in the future we can put out an 0.3.13 to fix it if we need to.

Please do check my backporting work. The only PR with the "backport pending 0.3" label that isn't yet included here is #12645, cc @timholy and see my recent comment there. I did just remove that label from #12934 and #12607 due to cherry-picking conflicts, but could be convinced otherwise if someone feels strongly.

stevengj and others added 7 commits October 20, 2015 07:18
…(NaN))

(cherry picked from commit e7e614d)
ref #12564

Fix test syntax to pass on 0.3
(cherry picked from commit 88f417d)
ref #12601

Fix test syntax to pass on 0.3
Add an unsatisfiable REQUIRES test

Add tests for Pkg.pin error cases

Adjust comment for issue number in a test

(cherry picked from commit 9d368d4)
ref #13420
and add corresponding tests

(cherry picked from commit 3a57ccb)
ref #13420
@tkelman
Copy link
Contributor Author

tkelman commented Oct 22, 2015

Oh, I need to set the git config in .travis.yml. Will fix that tomorrow.

@tkelman
Copy link
Contributor Author

tkelman commented Oct 23, 2015

@IainNZ any idea why PackageEvaluator refuses to finish a complete run here? 6+ times now on multiple machines. Partway through, packages start giving 0-size _add.log files and not outputting json files. This is extremely frustrating.

@IainNZ
Copy link
Member

IainNZ commented Oct 23, 2015

I've never experienced that before... obviously, works well on 0.3.11

@tkelman
Copy link
Contributor Author

tkelman commented Oct 23, 2015

No, it doesn't, not on any of the machines I've been trying to run it on. One of the VM's I'm testing on for this comparison is 0.3.11.

@IainNZ
Copy link
Member

IainNZ commented Oct 23, 2015

Hah, well, thats weird. The "obviously" was because its been working for me on my machine, Miles machine, and now nanosoldier for a while now. Are you running in split AL/MZ config?

@tkelman
Copy link
Contributor Author

tkelman commented Oct 23, 2015

Yes, though I also tried the "all" version and hit the same issue.

@tkelman
Copy link
Contributor Author

tkelman commented Oct 26, 2015

I did eventually get an entire run to go through, but it took way more attempts than I would have liked - https://gist.github.com/anonymous/d101e776fad97f46e1ab

The only newly failing package was RouletteWheels.jl (cc @jbn), not sure what's causing that (edit: seems okay locally). Oddly on 0.3.11, Dates froze, HTTPClient had an ERROR: test failed: r.http_code == 200 (flaky connection on nanosoldier maybe?) and OnlineStats had an ERROR: ArgumentError("Cauchy: the condition σ > zero(σ) is not satisfied.") but I suspect those are probably intermittent, rather than any of the changes here making them pass.

tkelman added a commit that referenced this pull request Oct 26, 2015
@tkelman tkelman merged commit 737a9a8 into release-0.3 Oct 26, 2015
@tkelman tkelman deleted the tk/backports-0.3.12 branch October 26, 2015 12:37
@IainNZ
Copy link
Member

IainNZ commented Oct 26, 2015

Dates has intermittently frozen for all of 0.3, and I've seen that for httpclient plenty too. Online stats problem sounds familiar

@tkelman
Copy link
Contributor Author

tkelman commented Oct 28, 2015

Note for future reference that without #7906, release-0.3 cannot be built on win32 using MARCH=pentium4, so the buildbot configuration needs to be temporarily adjusted to make things work. @staticfloat the binaries of 0.3.12 are ready in julianightlies, can you check Base.runtests() on mac?

@staticfloat
Copy link
Member

Base.runtests() passes with no errors on mac.

@tkelman
Copy link
Contributor Author

tkelman commented Oct 29, 2015

Great, thanks. Do you have a set of scripts you've been using for moving binaries from julianightlies to julialang? I imagine it needs to update the -latest files, create checksums and do the gpg signing, and make sure it sets the permissions to readable. Anything else? The gpg key is yours so I guess only you can do that one, but for the rest could you email me anything where it would help if I did it? Along with s3 credentials which I somehow don't have yet.

@staticfloat
Copy link
Member

No, I've just been doing it manually, using Cyberduck. I'm a little paranoid about automating stuff in the julialang bucket. We'll get you the access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants