Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents premature EOFError on blocking reads #13620

Closed
wants to merge 1 commit into from

Conversation

hessammehr
Copy link
Contributor

Blocks until the required number of bytes has been read. Only throws EOFError on actual EOF. Fixes #13559.

Blocks until the required number of bytes has been read. Only throws EOFError on actual EOF. Fixes JuliaLang#13559.
@pao
Copy link
Member

pao commented Oct 15, 2015

Travis failure is OOM killer. Can someone with the right permissions kick Travis now that #13577/#13621 are merged?

@nalimilan
Copy link
Member

@pao Done.

@pao
Copy link
Member

pao commented Oct 15, 2015

Thanks!

@tkelman
Copy link
Contributor

tkelman commented Oct 15, 2015

Changes to .travis.yml usually need a rebase to take effect.

Delete the now unused C function?

@pao
Copy link
Member

pao commented Oct 15, 2015

Changes to .travis.yml usually need a rebase to take effect.

Oh. Right. Duh. My bad. From the branch name this looks like this was submitted from the GitHub editor. @hessammehr, you feel up to doing the rebase?

@tkelman
Copy link
Contributor

tkelman commented Oct 15, 2015

A new commit to the same branch might also make Travis re-run the yml to sh conversion, I'm not positive. How Travis works can be subtle sometimes.

@pao
Copy link
Member

pao commented Oct 15, 2015

This branch would be missing the commits which update the .travis.yml, though, right?

@hessammehr
Copy link
Contributor Author

@pao The best I could manage was to point my master at patch-1, then rebase and open another pull request. I hope I didn't mess things up. The new PR is #13632.

@pao
Copy link
Member

pao commented Oct 15, 2015

That'll work. Superceded by #13632, then.

@tkelman
Copy link
Contributor

tkelman commented Oct 15, 2015

Travis might recompute for a new merge commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants