Fix doc bootstrap method error. #13602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Any easy way of testing the conditions that were breaking this? |
|
We could add a docstring really early in the build. Since this stuff gets replaced later on by the real docsystem that's probably the only way to go. Once #13534 is merged that would be a sufficient test, but I'll add a one to the |
Docstrings defined before `==` is available for `Symbol` comparisons causes a build error. Fix by comparing with `===`. Ref: JuliaLang#13534 (comment)
MichaelHatherly
force-pushed
the
mh/doc-bootstrap-fix
branch
from
eb033ba to
d8b6a24
Compare
This was referenced Oct 14, 2015
Closed
tkelman
added a commit
that referenced
this pull request
Oct 14, 2015
Fix doc bootstrap method error.
tkelman
pushed a commit
that referenced
this pull request
Oct 31, 2015
Docstrings defined before `==` is available for `Symbol` comparisons causes a build error. Fix by comparing with `===`. Ref: #13534 (comment) (cherry picked from commit d8b6a24) ref #13602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docstrings defined before
==is available forSymbolcomparisons causes a build error. Fix by comparing with===.Ref: #13534 (comment)