Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in atrepl #13535

Merged

Conversation

MichaelHatherly
Copy link
Member

Docs attached to numbers weren't being found. (ref https://groups.google.com/d/msg/julia-users/D7QE9oFj91Y/D5f4HKC2AgAJ)

Finding docs for specific methods using the syntax

help?> f(::Int)

wasn't being recognised due to changes in how gen_call_with_extracted_types generated an error when it failed. (Previously the error was thrown by the function, but is now returned as an :(error("...")) expression.)

Docs attached to numbers weren't being found.

Finding docs for specific methods using the syntax

    help?> f(::Int)

wasn't being recognised due to changes in how `gen_call_with_extracted_types`
generated an error when it failed. (Previously the error was thrown
by the function, but is now returned as an `:(error("..."))` expression.)
@tkelman tkelman added docsystem The documentation building system backport pending 0.4 labels Oct 10, 2015
@ihnorton
Copy link
Member

(related: #12737)

jakebolewski added a commit that referenced this pull request Oct 13, 2015
@jakebolewski jakebolewski merged commit b70c07c into JuliaLang:master Oct 13, 2015
@MichaelHatherly MichaelHatherly deleted the mh/fix-atrepl-regression branch October 14, 2015 06:10
tkelman pushed a commit that referenced this pull request Oct 31, 2015
Docs attached to numbers weren't being found.

Finding docs for specific methods using the syntax

    help?> f(::Int)

wasn't being recognised due to changes in how `gen_call_with_extracted_types`
generated an error when it failed. (Previously the error was thrown
by the function, but is now returned as an `:(error("..."))` expression.)

(cherry picked from commit 446ddaa)
ref #13535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docsystem The documentation building system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants