Bump libgit2, document libssl-dev build dep and fail earlier when missing #13448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess openssl requirements is a bit strict for libgit2 upstream, but for us it's a necessity. So, merge it. |
|
My patch for upstream is a little more complicated than the one here, adding a new option that's off by default so you could flag if you want the dependency to be mandatory. Let's see whether they approve of the idea. |
|
Would be nice if there's a |
|
Maybe we should have used that for the iconv issues on mac... |
tkelman
added a commit
that referenced
this pull request
Oct 6, 2015
Bump libgit2, document libssl-dev build dep and fail earlier when missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13389
The
REQUIRE_OPENSSLflag isn't used yet but I've proposed a PR to libgit2 upstream so it wouldn't be needed as a patch in future versions.