Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak @parallel for a small improvement in performance #12487

Merged
merged 1 commit into from
Aug 9, 2015
Merged

tweak @parallel for a small improvement in performance #12487

merged 1 commit into from
Aug 9, 2015

Conversation

amitmurthy
Copy link
Contributor

replaces @spawn/ fetch with remotecall_fetch

@amitmurthy
Copy link
Contributor Author

Seeking an explanation for something I didn't understand while making this change:

  • make_preduce_body calls localize_vars which returns an Expr object
  • preduce expects a Function as the second argument. What is passed is the return value of make_preduce_body. How does this work?

@kshyatt kshyatt added performance Must go faster parallelism Parallel or distributed computation labels Aug 7, 2015
@amitmurthy
Copy link
Contributor Author

How do I restart the AppVeyor build? The link points to some other PR.

@amitmurthy amitmurthy force-pushed the amitm/tweak_preduce branch from 86500f6 to 69088c7 Compare August 7, 2015 05:32
@amitmurthy
Copy link
Contributor Author

Just did a dummy rebase and force push. Appveyor now points to different PR. What is the way to fix this?

@ViralBShah
Copy link
Member

Something seems broken at Appveyor.

@tkelman
Copy link
Contributor

tkelman commented Aug 7, 2015

appveyor/ci#353 - either continue with new pushes, rebases or otherwise, or an alternative is going into the github settings and re-delivering the webhook. I'll do that and see if it works correctly.

@amitmurthy amitmurthy force-pushed the amitm/tweak_preduce branch from 69088c7 to 9c48da1 Compare August 8, 2015 04:32
amitmurthy added a commit that referenced this pull request Aug 9, 2015
@amitmurthy
Merge pull request #12487 from JuliaLang/amitm/tweak_preduce
783f870 
tweak @parallel for a small improvement in performance
@amitmurthy amitmurthy merged commit 783f870 into master Aug 9, 2015
@amitmurthy amitmurthy deleted the amitm/tweak_preduce branch August 9, 2015 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
parallelism Parallel or distributed computation performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amitmurthy @ViralBShah @tkelman @kshyatt