Move discussion about abstract types in fields from FAQ to performances #12429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request warns users against abstract fields in composite type. It's tricky for newcomers, and it's currently not really mentioned. Why should I do to have this merged? |
|
The bump is good--this just needs someone to review and agree that it's a good idea to make this change. |
jakebolewski
added a commit
that referenced
this pull request
Oct 2, 2015
Move discussion about abstract types in fields from FAQ to performances
|
Thanks! |
|
I believe the underlines need to be the same length as the titles in rst |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without reorganizing anything else in the performances page [av skip]