-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: re-export localindexes [ci skip] #12423
Conversation
removing too many exports isn't necessarily a bad thing... |
Sure, if we want to leave this un-exported, that would be fine. But since it seems to have been an accident, I thought I'd raise it for discussion. CC @amitmurthy. |
I am for re-exporting, now that SharedArrays are not being marked as experimental and because this is a useful api for work partitioning. |
ea73e58
to
1aec2d3
Compare
1aec2d3
to
a39bdc9
Compare
@one-more-minute, I just rebased this attempting to work with the new documentation system. (The "Blah blah" part of this commit is obviously something I might have to reevaluate, so consider this a WIP 😄.) Unfortunately, after
Can you provide a bit more guidance about how we're supposed to proceed? I've read both http://docs.julialang.org/en/latest/manual/documentation/ and https://groups.google.com/d/msg/julia-users/eI-mZe2zA-c/kmc7RdPPAQAJ, is there some other place I should be looking? |
Not sure if the doc stuff will run as part of make, but you can force it with |
Moving to But no dice on the RST documentation (still "Blah blah"). I did this order: make
./julia doc/genstdlib.jl
make -C doc html
firefox doc/_build/html/index.html & |
Ah, I forgot – since your docstring is in Markdown it needs #12435 in order to output to RST. If you leave it as it is I'll make sure that gets fixed as part of that PR. |
Would it help to just push the RST rendering backend part of that PR (and a test) to master? Rendering currently-markdown docstrings into RST is something people are going to want to do now, but converting all of the RST in helpdb into markdown might take a while to get totally right. |
Yeah, that makes sense, I went ahead and pushed that commit, so that should make things easier for this PR. |
I rebased on top of aff076d, but without moving the docstring to |
@@ -703,6 +703,10 @@ Shared Arrays (Experimental, UNIX-only feature) | |||
Returns the index of the current worker into the ``pids`` vector, i.e., the list of workers mapping | |||
the SharedArray | |||
|
|||
.. function:: localindexes(S::SharedArray) | |||
|
|||
Blah blah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was me testing the new documentation system---see the history in #12423. This will not be part of the final commit.
Subsumed in 9c595c3 |
The doc addition for it wasn't though? |
Good point. Leaving this open, short on time right now. |
Superseded by #14532. |
Ref #12412 (comment)