Even more math tests, and a missing besselhx export #12169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
test
|
@pao Has a decision on that issue been reached? If the plan is to strip the special functions pretty soon I'd be happy to remove that commit from this PR. |
|
Probably not prior to 0.4 unless someone feels motivated enough to go and do it. This is just one thing among many that can be moved out to a package (and here also translated from Fortran to pure-Julia code) as part of #5155. |
|
I mention it more so there's a breadcrumb if that gets picked back up. A more salient reminder that it will need a resync. |
|
Ah, ok, thanks :). This look ok to folks? |
kshyatt
added a commit
that referenced
this pull request
Jul 16, 2015
Even more math tests, and a missing besselhx export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
besselhxwasn't exported fromBase.Math. I've fixed that and added some more tests for it and a few other Bessel functions. I also fixed some badsymmetric.jltests I wrote and added the last two missing tests forUniformScaling.