fix parallel build and $PATH in LLVM sub-make #11564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added a commit
that referenced
this pull request
Jun 4, 2015
fix parallel build and $PATH in LLVM sub-make see https://savannah.gnu.org/bugs/index.php?45252
|
thanks for the link to the gnu make bug report to make this easy to review |
|
This broke the Windows buildbots, needs quoting around PATH http://buildbot.e.ip.saba.us:8010/builders/package_win8.1-x64/builds/812 edit: should be fixed by 4a313de |
tkelman
added a commit
that referenced
this pull request
Jun 4, 2015
ref #11564 (comment) [ci skip] since CI uses binaries of LLVM, not a source build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a parallel build without this patch,
make -jNgives me thejobserver unavailablewarning while building LLVM.The only change that should be needed is on line 650, but there seems to be a bug in GNU Make that prevents it from recognizing that the third command in the expansion of
make-installis a sub-make, so I explicitly prefixed the corresponding command with+. This has been reported to GNU Make as bug #45252.