Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove julia 0.3 deprecations #11046

Merged
merged 2 commits into from
Apr 29, 2015
Merged

Remove julia 0.3 deprecations #11046

merged 2 commits into from
Apr 29, 2015

Conversation

Keno
Copy link
Member

@Keno Keno commented Apr 28, 2015

Seems like the time is about right, plus Gadfly is broken right now because of the Stat deprecation, so if we're gonna remove the deprecations anyway, might as well do it now.

@StefanKarpinski
Copy link
Member

+1

@JeffBezanson
Copy link
Member

Should we also flip the switch to get the new behavior of [a, b]?

@StefanKarpinski
Copy link
Member

Don't we need to go through a deprecation cycle for that? I.e. wait until 0.5-dev.

@JeffBezanson
Copy link
Member

The main problem with that is the rather severe overhead of this code:

for a in X

Making arrays from mixed types with [ ] is currently about 4x slower than in 0.3 (e.g. #4467).

@kmsquire
Copy link
Member

That would be good motivation to make the 0.5 development cycle really short. ;-)

@Keno
Copy link
Member Author

Keno commented Apr 29, 2015

I think the [a, b] switch needs to stay for 0.4 unfortunately. In any case, it should not be part of this commit, so I'll go ahead and merge.

Keno added a commit that referenced this pull request Apr 29, 2015
@Keno Keno merged commit 048706a into master Apr 29, 2015
@tkelman
Copy link
Contributor

tkelman commented Apr 29, 2015

Looks like there weren't too many of these, but I think the right time to do this would have been coordinated with transitioning from 0.4-dev to 0.4-pre, and we still have several breaking changes open so I don't think we're ready for that quite yet.

@tkelman tkelman deleted the kf/deprecations branch April 29, 2015 03:44
@IainNZ
Copy link
Member

IainNZ commented May 2, 2015

This was fairly breaking, it turns out, although it might just be in a couple of base packages. Mostly Range1.

@Keno
Copy link
Member Author

Keno commented May 2, 2015

A lot of packages have been updated but not tagged yet.

@tkelman
Copy link
Contributor

tkelman commented May 15, 2015

Do we have a doctest to make sure we remove the docs of deprecated functions? Either before or after we remove the last method definitions?

@IainNZ IainNZ mentioned this pull request Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants