added getsockname for determining a socket name (address & port) of the running server

[wildart]

I added getsockname for determining a socket name (address & port) of the running server. When server socket bound to INPORT_ANY port (0), during listen call the socket is automatically bound to a random free port. By calling getsockname, you can get value of the assigned port.

In addition, I fixed a missing IPv6 support for bind and some documentation.

[tkelman]

Any idea why this fails on windows? Implementation issue, or OS limitation?

[wildart]

Appveyor failed of this test on Windows, I guess they do not have IPv6 available on test machine. I'll turn if back. Problem is how to tell if IPv6 is on or not before executing this test. Or should I remove it?

[ihnorton]

see #9882 and #10335

On Thu, Apr 30, 2015 at 2:17 PM, Art [email protected] wrote:

In test/socket.jl
#11012 (comment):

+begin

• default_port = UInt16(11011)
• default_addr = IPv4("127.0.1.1")

• sock = Base.TCPServer()
• bind(sock,Base.InetAddr(default_addr,default_port))
• listen(sock)

• new_addr, new_port = getsockname(sock)

• @test default_addr == new_addr
• @test default_port == new_port
• close(sock)
  +end

+@unix_only begin

Appveyor failed of this test on Windows, I guess they do not have IPv6
available on test machine. I'll turn if back. Problem is how to tell if
IPv6 is on or not before executing this test. Or should I remove it?

—
Reply to this email directly or view it on GitHub
https://github.com/JuliaLang/julia/pull/11012/files#r29455402.

[wildart]

Closed by mistake.

[amitmurthy]

@wildart , thanks for the PR. Please rebase against current master. While rebasing you will need to delete

julia/src/jl_uv.c

Lines 693 to 704 in 9c82059

	DLLEXPORT int jl_tcp_getsockname_v4(uv_tcp_t *handle, uint32_t * ip, uint16_t * port)
	{
	struct sockaddr_in name;
	int len = sizeof(name);
	if (uv_tcp_getsockname(handle, (struct sockaddr *)&name, &len)) {
	return -1;
	}
	*ip = ntohl(name.sin_addr.s_addr);
	*port = ntohs(name.sin_port);
	return 0;
	}

and change the call in managers.jl accordingly.

[malmaud]

Since this won't make it into Julia .4, maybe we could carve out the essential part of this PR and move it to JuliaWeb now.

[wildart]

@malmaud You still need uv_tcp_getsockname call. Do you mean to address libuv directly? PR could be added in following updates.

[malmaud]

Ya, there is nothing technically blocking us from directly addressing libuv in a package, is there? It would just be temporary until the functionality is moved into base in .5.

[malmaud]

@wildart, want to rebase this? Would be cool to get it into .5.

[wildart]

Rebased and fixed errors, it's ready to merge.

[tkelman]

Doc changes here need to be reflected in helpdb

[wildart]

Done.

[tkelman]

should this be getipaddr() -> IPAddr?

[wildart]

Crap, it's so good to have duplicate documentations.

[wildart]

Ready.

[ihnorton]

Ah, nevermind.

[malmaud]

Great, glad to finally have this functionality.