Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: for llvmcall #10760

Merged
merged 1 commit into from
Oct 20, 2015
Merged

doc: for llvmcall #10760

merged 1 commit into from
Oct 20, 2015

Conversation

ihnorton
Copy link
Member

@ihnorton ihnorton commented Apr 7, 2015

To get this started anyway.

@ihnorton
Copy link
Member Author

ihnorton commented Apr 7, 2015

#8919

(see also the documentation for each of these functions for further details).
In most cases, this simply results in a call to ``convert(ArgumentType, ArgumentValue)``.

See ``test/llvmcall.jl`` for usage examples.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does
``test/llvmcall.jl
https://github.com/JuliaLang/julia/blob/master/test/llvmcall.jl_ work in this context?

@vchuravy
Copy link
Member

So the changes for #11604 would be:

  • llvmcall accepts as first argument a tuple of form (decl::String, IR::String), where decl can contain a single declaration or multiple.

Also the second argument should be a of form Tuple{Type1, ...}

@kshyatt kshyatt added the docs This change adds or pertains to documentation label Jul 2, 2015
@jakebolewski
Copy link
Member

Bump, it would seem useful to get this in.

@ihnorton
Copy link
Member Author

Rebased.

@tkelman
Copy link
Contributor

tkelman commented Oct 18, 2015

Needs to go in helpdb now I think?

@ihnorton
Copy link
Member Author

I believe I have sacrificed the proper number of rare newts to satisfy the docsys god here. Also included other minor changes from running genstdlib.

There was an error about a missing shell script on travis, but I restarted and it seems to have proceeded this time.

unique(f, itr)

Returns an array containing one value from ``itr`` for each unique value produced by ``f`` applied to elements of ``itr``\ .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind fixing this to become a proper function entry?

Ref #13622 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, but I've hit my non-deterministic error rate-limit for the day. The system refuses to recognize the function signatures. (yes, I rebuilt Julia, matched the signatures in helpdb and collections.rst, rebuilt julia again, ...).

Also, every 3rd or 4th run of genstdlib I get:

ERROR: LoadError: UnicodeError: invalid character index
 [inlined code] from ./int.jl:187

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(note that there are several different signatures, and the one in set.jl that takes an unspecified iterable is different from unique(::AbstractArray, dim::Int) definition in multi.jl. I tried a variety of different combinations, including splitting the doc strings up)

ihnorton added a commit that referenced this pull request Oct 20, 2015
@ihnorton ihnorton merged commit e60d546 into JuliaLang:master Oct 20, 2015
@ihnorton ihnorton deleted the docllvmcall branch October 20, 2015 18:46
ihnorton added a commit that referenced this pull request Oct 31, 2015
(cherry picked from commit a957dae)
ref #10760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants