Only dlload sysimg in one place #10270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there's too much code duplication between this if-branch should be written to only affect windows builds |
ihnorton
changed the title
|
Alright, refactored a little bit so there is only one call to load the sysimage. It's still hard to follow but I'm not sure how to get around the ordering requirements. |
Lightly refactor to make this somewhat more maintainable. fixes JuliaLang#10111
|
+1 |
ihnorton
added a commit
that referenced
this pull request
Feb 23, 2015
Only dlload sysimg in one place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10111