Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

observed failure of TestPkg thread test #54813

Closed
vtjnash opened this issue Jun 15, 2024 · 0 comments · Fixed by #54898
Closed

observed failure of TestPkg thread test #54813

vtjnash opened this issue Jun 15, 2024 · 0 comments · Fixed by #54898
Labels
bug Indicates an unexpected problem or unintended behavior correctness bug ⚠ Bugs that are likely to lead to incorrect results in user code without throwing multithreading Base.Threads and related functionality regression 1.11 Regression in the 1.11 release
Milestone
1.11

Comments

@vtjnash
Copy link
Member

vtjnash commented Jun 15, 2024

This is a test that calling using TestPkg on multiple threads will not result in accidentally emitting "Replacing module" text. However it seems broken at the moment (on f4b81af), as it can be made to fail by corrupting the test in progress:

131 vtjnash@deepsea4:~/julia/test$ JULIA_NUM_THREADS=8 ~/rr/bin/rr ../julia threads_exec.jl                                                                                                                                  
rr: Saving execution to trace directory `/home/vtjnash/.local/share/rr/julia-74'.                                                                                                                                            
Precompiling TestPkg...                                                                                       
  1 dependency successfully precompiled in 2 seconds                                                          
┌ Warning: The call to compilecache failed to create a usable precompiled cache file for TestPkg [69145d58-7df6-11e8-0660-cf7622583916]                                                                                      
│   exception = Error reading package image file.                                                                                                                                                                            
└ @ Base loading.jl:2454                                                                                                                                                                                                     
┌ Warning: Replacing module `TestPkg`                                                                                                                                                                                        
└ @ Base loading.jl:2311                                                                                                                                                                                                     
┌ Warning: The call to compilecache failed to create a usable precompiled cache file for TestPkg [69145d58-7df6-11e8-0660-cf7622583916]                                                                                      
│   exception = Error reading package image file.                                                                                                                                                                            
└ @ Base loading.jl:2454                                                                                                                                                                                                     
┌ Warning: Replacing module `TestPkg`                                                                                                                                                                                        
└ @ Base loading.jl:2311                                                                                      
┌ Warning: The call to compilecache failed to create a usable precompiled cache file for TestPkg [69145d58-7df6-11e8-0660-cf7622583916]                                                                                      
│   exception = Error reading package image file.                                                             
└ @ Base loading.jl:2454                                                                                      
┌ Warning: Replacing module `TestPkg`                                                                         
└ @ Base loading.jl:2311                                                                                      
┌ Warning: The call to compilecache failed to create a usable precompiled cache file for TestPkg [69145d58-7df6-11e8-0660-cf7622583916]                                                                                      
│   exception = Error reading package image file.                                                             
└ @ Base loading.jl:2454                                                                                      
┌ Warning: Replacing module `TestPkg`                                                                         
└ @ Base loading.jl:2311                                                                                      
┌ Warning: The call to compilecache failed to create a usable precompiled cache file for TestPkg [69145d58-7df6-11e8-0660-cf7622583916]                                                                                      
│   exception = Error reading package image file.                                                             
└ @ Base loading.jl:2454                                                                                                                                                                                                     
┌ Warning: Replacing module `TestPkg`                                                                                                                                                                                        
└ @ Base loading.jl:2311                                                                                      
┌ Warning: The call to compilecache failed to create a usable precompiled cache file for TestPkg [69145d58-7df6-11e8-0660-cf7622583916]                                                                                      
│   exception = Error reading package image file.                                                             
└ @ Base loading.jl:2454                                                                                      
┌ Warning: Replacing module `TestPkg`                                                                         
└ @ Base loading.jl:2311                                                                                                                                                                                                     
┌ Warning: The call to compilecache failed to create a usable precompiled cache file for TestPkg [69145d58-7df6-11e8-0660-cf7622583916]                                                                                      
│   exception = Error reading package image file.
└ @ Base loading.jl:2454                                                                                      
┌ Warning: Replacing module `TestPkg`                                                                                                                                                                                        
└ @ Base loading.jl:2311
@vtjnash vtjnash added bug Indicates an unexpected problem or unintended behavior multithreading Base.Threads and related functionality correctness bug ⚠ Bugs that are likely to lead to incorrect results in user code without throwing regression 1.11 Regression in the 1.11 release labels Jun 15, 2024
@vtjnash vtjnash added this to the 1.11 milestone Jun 19, 2024
vtjnash added a commit that referenced this issue Jun 23, 2024
@vtjnash
fix concurrent module loading return value
62cb02b 
Previously this might return `nothing` which would confuse the caller of
`start_loading` which expects that to mean the Module didn't load. It is
not entirely clear if this code ever worked, even single-threaded.

Fix #54813
@vtjnash vtjnash mentioned this issue Jun 23, 2024
Merged
vtjnash added a commit that referenced this issue Jun 24, 2024
@vtjnash
fix concurrent module loading return value
9d7d27b 
Previously this might return `nothing` which would confuse the caller of
`start_loading` which expects that to mean the Module didn't load. It is
not entirely clear if this code ever worked, even single-threaded.

Fix #54813
@vtjnash vtjnash closed this as completed in 0ef2bb6 Jul 7, 2024
KristofferC pushed a commit that referenced this issue Jul 12, 2024
@vtjnash @KristofferC
fix concurrent module loading return value (#54898)
4929aa2 
Previously this might return `nothing` which would confuse the caller of
`start_loading` which expects that to mean the Module didn't load. It is
not entirely clear if this code ever worked, even single-threaded.

Fix #54813

(cherry picked from commit 0ef2bb6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior correctness bug ⚠ Bugs that are likely to lead to incorrect results in user code without throwing multithreading Base.Threads and related functionality regression 1.11 Regression in the 1.11 release
Projects
None yet
Milestone
1.11
Development

Successfully merging a pull request may close this issue.

fix concurrent module loading return value JuliaLang/julia
1 participant
@vtjnash