Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] need shim for FieldError #54807

Closed
vtjnash opened this issue Jun 14, 2024 · 1 comment
Closed

[Test] need shim for FieldError #54807

vtjnash opened this issue Jun 14, 2024 · 1 comment
Labels
testsystem The unit testing framework and Test stdlib

Comments

@vtjnash
Copy link
Member

vtjnash commented Jun 14, 2024

Similar to our shim for @test_throws with LoadError, we may need a shim for FieldError. Some examples:
https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_date/2024-06/13/UnPack.primary.log
https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_date/2024-06/13/Parameters.primary.log
https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_date/2024-06/13/FunctionOperators.primary.log

@vtjnash vtjnash added the testsystem The unit testing framework and Test stdlib label Jun 14, 2024
LilithHafner added a commit that referenced this issue Jun 15, 2024
Original commit introducing FieldError exception is 7e5d9a3. Since
existing packages were using `ErrorException` to capture `no field`
errors, we need to have a shim to avoid test breaks for external
packages with such uses until they update to `FieldError`.

addressing `need shim for FieldError` #54807

---------

Co-authored-by: Lilith Orion Hafner <[email protected]>
@arhik
Copy link
Contributor

arhik commented Jun 18, 2024

@vtjnash this can be closed if the merged PR meets your issue.

@vtjnash vtjnash closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testsystem The unit testing framework and Test stdlib
Projects
None yet
Development

No branches or pull requests

2 participants