Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core.EnterNode is showing up in Method.roots list #53248

Closed
vtjnash opened this issue Feb 8, 2024 · 1 comment · Fixed by #53482
Closed

Core.EnterNode is showing up in Method.roots list #53248

vtjnash opened this issue Feb 8, 2024 · 1 comment · Fixed by #53482
Assignees
@JeffBezanson
Labels
compiler:inference Type inference regression Regression in behavior compared to a previous version
Milestone
1.11

Comments

@vtjnash
Copy link
Member

vtjnash commented Feb 8, 2024

This seems to be a bug introduced when Core.EnterNode was split off from Expr(:enter)
@vtjnash vtjnash added regression Regression in behavior compared to a previous version compiler:inference Type inference labels Feb 8, 2024
@vtjnash vtjnash added this to the 1.11 milestone Feb 8, 2024
@gbaraldi
Copy link
Member

gbaraldi commented Feb 8, 2024

filter(x->typeof(x) === Core.EnterNode,methods(lock)[13].roots) this shows a couple of them for example

@JeffBezanson JeffBezanson self-assigned this Feb 26, 2024
JeffBezanson added a commit that referenced this issue Feb 26, 2024
@JeffBezanson
add IR encoding for EnterNode
5e25ed7 
fixes #53248
@JeffBezanson JeffBezanson mentioned this issue Feb 26, 2024
Merged
vtjnash pushed a commit that referenced this issue Feb 27, 2024
@JeffBezanson
add IR encoding for EnterNode (#53482)
b3b2736 
fixes #53248
KristofferC pushed a commit that referenced this issue Mar 1, 2024
@JeffBezanson @KristofferC
add IR encoding for EnterNode (#53482)
6abaed1 
fixes #53248

(cherry picked from commit b3b2736)
tecosaur pushed a commit to tecosaur/julia that referenced this issue Mar 4, 2024
@JeffBezanson @tecosaur
add IR encoding for EnterNode (JuliaLang#53482)
f6a2ba7 
fixes JuliaLang#53248
mkitti pushed a commit to mkitti/julia that referenced this issue Mar 7, 2024
@JeffBezanson @mkitti
add IR encoding for EnterNode (JuliaLang#53482)
9e9386a 
fixes JuliaLang#53248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffBezanson JeffBezanson

Labels
compiler:inference Type inference regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
1.11
Development

Successfully merging a pull request may close this issue.

add IR encoding for EnterNode JuliaLang/julia
3 participants
@vtjnash @JeffBezanson @gbaraldi