Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcat between type and number fails after SparseArrays is loaded #51826

Closed
KristofferC opened this issue Oct 23, 2023 · 0 comments · Fixed by JuliaSparse/SparseArrays.jl#464
Closed

vcat between type and number fails after SparseArrays is loaded #51826

KristofferC opened this issue Oct 23, 2023 · 0 comments · Fixed by JuliaSparse/SparseArrays.jl#464
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@KristofferC
Copy link
Member 

julia> [Int; 1]
2-element Vector{Any}:
  Int64
 1

julia> using SparseArrays

julia> [Int; 1]
ERROR: invoke: argument type error
Stacktrace:
 [1] vcat(n1::Type{Int64}, ns::Int64)
   @ SparseArrays ~/julia/usr/share/julia/stdlib/v1.11/SparseArrays/src/sparsevector.jl:1300
 [2] top-level scope
   @ REPL[2]:1

cc @vtjnash
@KristofferC KristofferC added the bug Indicates an unexpected problem or unintended behavior label Oct 23, 2023
vtjnash added a commit that referenced this issue Oct 23, 2023
@vtjnash
improve error message for invoke
2d7692a 
This is effectively a type-assert, but the error message sounded
confusing and internal without the context of what it got and what it
expected to get.

Refs: #51826
@vtjnash vtjnash mentioned this issue Oct 23, 2023
Merged
vtjnash added a commit to JuliaSparse/SparseArrays.jl that referenced this issue Oct 23, 2023
@vtjnash
fix h/vcat invoke dispatch arguments
60f39f5 
Fixes JuliaLang/julia#51826
@vtjnash vtjnash mentioned this issue Oct 23, 2023
Merged
KristofferC pushed a commit to JuliaSparse/SparseArrays.jl that referenced this issue Oct 24, 2023
@vtjnash
fix h/vcat invoke dispatch arguments (#464)
0b36fdd 
Fixes JuliaLang/julia#51826
KristofferC pushed a commit to JuliaSparse/SparseArrays.jl that referenced this issue Oct 24, 2023
@vtjnash
fix h/vcat invoke dispatch arguments (#464)
fa6269b 
Fixes JuliaLang/julia#51826

(cherry picked from commit 0b36fdd)
vtjnash added a commit that referenced this issue Oct 24, 2023
@vtjnash
improve error message for invoke
ef7dc78 
This is effectively a type-assert, but the error message sounded
confusing and internal without the context of what it got and what it
expected to get.

Refs: #51826
vtjnash added a commit that referenced this issue Oct 25, 2023
@vtjnash
improve error message for invoke (#51831)
193ead2 
This is effectively a type-assert, but the error message sounded
confusing and internal without the context of what it got and what it
expected to get.

Refs: #51826

after:
`ERROR: TypeError: in invoke: argument type error, expected Tuple{Int64,
Vararg{Int64}}, got a value of type Tuple{DataType, Int64}`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix h/vcat invoke dispatch arguments JuliaSparse/SparseArrays.jl
1 participant
@KristofferC