Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression in stacktrace correctness with type information truncation #50575

Closed
vtjnash opened this issue Jul 17, 2023 · 0 comments · Fixed by #50598
Closed

regression in stacktrace correctness with type information truncation #50575

vtjnash opened this issue Jul 17, 2023 · 0 comments · Fixed by #50598
Assignees
@JeffBezanson
Labels
display and printing Aesthetics and correctness of printed representations of objects. regression Regression in behavior compared to a previous version
Milestone
1.10

Comments

@vtjnash
Copy link
Member

vtjnash commented Jul 17, 2023 

 [23] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{…}, dl_load_path::Vector{…}, load_path::Vector{…}, concrete_deps::Vector{…}, source::String)
    @ Base ./loading.jl:2216
 [24] top-level scope
    @ stdin:3
Some type information was truncated. Use `show(err)` to see complete types.
in expression starting at /home/pkgeval/.julia/packages/SimpleWorkflows/GNXa7/src/SimpleWorkflows.jl:1
in expression starting at stdin:3

https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_date/2023-07/14/SimpleWorkflows.primary.log

This now says "use show(err)", but the err variable does not exist, so this message is now factually incorrect.
@vtjnash vtjnash added this to the 1.10 milestone Jul 17, 2023
@vtjnash vtjnash added regression Regression in behavior compared to a previous version display and printing Aesthetics and correctness of printed representations of objects. labels Jul 17, 2023
@JeffBezanson JeffBezanson self-assigned this Jul 19, 2023
JeffBezanson added a commit that referenced this issue Jul 19, 2023
@JeffBezanson
only print show(err) suggestion for limited types in REPL
1dcb6d6 
fixes #50575
@JeffBezanson JeffBezanson mentioned this issue Jul 19, 2023
Merged
JeffBezanson added a commit that referenced this issue Jul 19, 2023
@JeffBezanson
only print show(err) suggestion for limited types in REPL
dd3e37d 
fixes #50575
JeffBezanson added a commit that referenced this issue Jul 19, 2023
@JeffBezanson
only limit types in stack traces in the REPL
5c2359b 
move `show(err)` suggestion to REPL since the REPL sets `err`

fixes #50575
JeffBezanson added a commit that referenced this issue Aug 1, 2023
@JeffBezanson @aviatesk
only limit types in stack traces in the REPL (#50598)
9822257 
fixes #50575

Co-authored-by: Shuhei Kadowaki <[email protected]>
KristofferC pushed a commit that referenced this issue Aug 10, 2023
@JeffBezanson @KristofferC
only limit types in stack traces in the REPL (#50598)
2e71492 
fixes #50575

Co-authored-by: Shuhei Kadowaki <[email protected]>
(cherry picked from commit 9822257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffBezanson JeffBezanson

Labels
display and printing Aesthetics and correctness of printed representations of objects. regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
1.10
Development

Successfully merging a pull request may close this issue.

only limit types in stack traces in the REPL JuliaLang/julia
2 participants
@vtjnash @JeffBezanson