Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profile format=:flat has wrong overhead #49732

Closed
vtjnash opened this issue May 10, 2023 · 0 comments · Fixed by #49824
Closed

profile format=:flat has wrong overhead #49732

vtjnash opened this issue May 10, 2023 · 0 comments · Fixed by #49824
Labels
profiler

Comments

@vtjnash
Copy link
Member

vtjnash commented May 10, 2023

for example, I made this profile:

Profile.print(C=true,format=:flat,sortedby=:overhead)

    17         1 /Users/jameson/julia1/src/subtype.c                                                                                                    343 obviously_egal
     8         1 /Users/jameson/julia1/src/subtype.c                                                                                                    770 var_gt
     4         1 /Users/jameson/julia1/src/subtype.c                                                                                                    646 subtype_ccheck
     9         1 /Users/jameson/julia1/src/subtype.c                                                                                                   1451 subtype
     8         1 /Users/jameson/julia1/src/jltypes.c                                                                                                    533 flatten_type_union
   206         2 /usr/lib/system/libsystem_malloc.dylib                                                                                                   ? _nanov2_free
     5         2 /Users/jameson/julia1/src/jltypes.c                                                                                                    826 simple_intersect
   213         3 /usr/lib/system/libsystem_malloc.dylib                                                                                                   ? nanov2_malloc
    19         3 /usr/lib/system/libsystem_malloc.dylib                                                                                                   ? free
    13         3 /usr/lib/system/libsystem_malloc.dylib                                                                                                   ? _malloc_zone_malloc
    14         3 /Users/jameson/julia1/src/subtype.c                                                                                                    981 subtype_unionall
     3         3 /usr/lib/system/libsystem_malloc.dylib                                                                                                   ? malloc
     8         5 /Users/jameson/julia1/src/jltypes.c                                                                                                   1483 jl_unwrap_unionall
    11         5 /usr/lib/system/libsystem_kernel.dylib                                                                                                   ? __error
   108         6 /Users/jameson/julia1/src/jltypes.c                                                                                                    154 has_free_typevars
    23         6 /Users/jameson/julia1/src/subtype.c                                                                                                   1546 local_forall_exists_subtype
    21        14 /usr/lib/system/libsystem_pthread.dylib                                                                                                  ? pthread_getspecific
    26        26 /usr/lib/system/libsystem_platform.dylib                                                                                                 ? [unknown function]
    32        32 /Users/jameson/julia1/usr/lib/libjulia-internal.1.10.dylib                                                                               ? [unknown function]
   118       118 /usr/lib/system/libsystem_platform.dylib                                                                                                 ? _platform_memmove$VARIANT$Haswell
   189       189 /usr/lib/system/libsystem_platform.dylib                                                                                                 ? _platform_bzero$VARIANT$Haswell
  6271      6271 /Users/jameson/julia1/src/jlapi.c                                                                                                      734 jl_repl_entrypoint

Gabriel noted that is has attributed overhead to the root node, instead of the leaf node, so it might be processing this counter in the wrong direction now
vtjnash added a commit that referenced this issue May 15, 2023
@vtjnash
[Profile]: fix overhead counts in format=:flat
2c404d7 
Regression caused by #41742, which inverted the loop without inverting
the logic. And fix a number of related formatting mistakes.

Fix #49732
vtjnash added a commit that referenced this issue May 15, 2023
@vtjnash
[Profile] fix overhead counts in format=:flat
ec8b586 
Regression caused by #41742, which inverted the loop without inverting
the logic. And fix a number of related formatting mistakes.

Fix #49732
@vtjnash vtjnash mentioned this issue May 15, 2023
Merged
vtjnash added a commit that referenced this issue May 16, 2023
@vtjnash
[Profile] fix overhead counts in format=:flat (#49824)
45748b8 
Regression caused by #41742, which inverted the loop without inverting
the logic. And fix a number of related formatting mistakes.

Fix #49732
KristofferC pushed a commit that referenced this issue May 19, 2023
@vtjnash
[Profile] fix overhead counts in format=:flat (#49824)
c0e2507 
Regression caused by #41742, which inverted the loop without inverting
the logic. And fix a number of related formatting mistakes.

Fix #49732

(cherry picked from commit 45748b8)
KristofferC pushed a commit that referenced this issue May 27, 2023
@vtjnash @KristofferC
[Profile] fix overhead counts in format=:flat (#49824)
f07ed54 
Regression caused by #41742, which inverted the loop without inverting
the logic. And fix a number of related formatting mistakes.

Fix #49732

(cherry picked from commit 45748b8)
kpamnany pushed a commit that referenced this issue Jun 21, 2023
@vtjnash @kpamnany
[Profile] fix overhead counts in format=:flat (#49824)
f7b0953 
Regression caused by #41742, which inverted the loop without inverting
the logic. And fix a number of related formatting mistakes.

Fix #49732

(cherry picked from commit 45748b8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
profiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Profile] fix overhead counts in format=:flat JuliaLang/julia
1 participant
@vtjnash