Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression in methods lookup #49408

Closed
vtjnash opened this issue Apr 18, 2023 · 1 comment · Fixed by #49416
Closed

regression in methods lookup #49408

vtjnash opened this issue Apr 18, 2023 · 1 comment · Fixed by #49416
Labels
bug Indicates an unexpected problem or unintended behavior regression Regression in behavior compared to a previous version
Milestone
1.10

Comments

@vtjnash
Copy link
Member

vtjnash commented Apr 18, 2023 

julia> methods(Base.Broadcast.broadcasted, Tuple{Base.Broadcast.BroadcastStyle, Any, Vararg})
# 1 method for generic function "broadcasted" from Base.Broadcast:
 [1] broadcasted(::S, f, args...) where S<:Base.Broadcast.BroadcastStyle
     @ broadcast.jl:1337

(there should be about 48 of these, for various subtypes of Base.Broadcast.BroadcastStyle)
@vtjnash vtjnash added bug Indicates an unexpected problem or unintended behavior regression Regression in behavior compared to a previous version labels Apr 18, 2023
@maleadt
Copy link
Member

maleadt commented Apr 19, 2023 •
edited
Loading 

eb4b1a78388c4a2d2c93dac303c61bdb98052dbe is the first bad commit
commit eb4b1a78388c4a2d2c93dac303c61bdb98052dbe
Author: Jameson Nash <[email protected]>
Date:   Tue Mar 7 21:21:00 2023 -0500

    typemap: improve quality of leaf split (#48925)

    Introduce another optional layer of indirection, doing lookup on first
    typename always, then leaftypes. This lets the intersection-iterators
    skip a lot of jl_isa queries later.

ref #48925

@N5N3 N5N3 added this to the 1.10 milestone Apr 19, 2023
vtjnash added a commit that referenced this issue Apr 19, 2023
@vtjnash
fix regression in methods lookup
68bbfd7 
Certain queries were searching for Type{T} instead of T due to a
mistaken tparam setting, resulting in missing methods in lookup.

Fix #49408
Ref #48925
@vtjnash vtjnash mentioned this issue Apr 19, 2023
Merged
vtjnash added a commit that referenced this issue Apr 20, 2023
@vtjnash
fix regression in methods lookup (#49416)
ca50706 
Certain queries were searching for Type{T} instead of T due to a
mistaken tparam setting, resulting in missing methods in lookup.

Fix #49408
Ref #48925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
1.10
Development

Successfully merging a pull request may close this issue.

fix regression in methods lookup JuliaLang/julia
3 participants
@vtjnash @maleadt @N5N3