Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort_by is broken #460

Closed
StefanKarpinski opened this issue Feb 25, 2012 · 2 comments
Closed

sort_by is broken #460

StefanKarpinski opened this issue Feb 25, 2012 · 2 comments
Assignees
@StefanKarpinski
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@StefanKarpinski
Copy link
Member

The mutating versionsort_by! is fine.
@ghost ghost assigned StefanKarpinski Feb 25, 2012
@JeffBezanson
Copy link
Member

Does this fix it:

diff --git a/j/sort.j b/j/sort.j
index 88502b2..51b1c4d 100644
--- a/j/sort.j
+++ b/j/sort.j
@@ -309,7 +309,7 @@ end
 @in_place_matrix_op sort
 @in_place_matrix_op sort lt::Function
 @in_place_matrix_op sortr
-@in_place_matrix_op sort_by
+@in_place_matrix_op sort_by by::Function

?

@StefanKarpinski
Copy link
Member Author

I dunno. I tried that while we were on the phone and it didn't seem to. Can try again.

StefanKarpinski pushed a commit that referenced this issue Feb 8, 2018
@fredrikekre
Compat.Random (#460)
37a1150
@vchuravy vchuravy mentioned this issue Feb 8, 2018
Closed
LilithHafner pushed a commit to LilithHafner/julia that referenced this issue Oct 11, 2021
@mateuszbaran @nalimilan
Basic abstract covariance estimation interface (JuliaLang#460)
24a80ca
cmcaine pushed a commit to cmcaine/julia that referenced this issue Nov 11, 2022
@serialhex
Add authors and fix file name (JuliaLang#460)
8256b45 
* add authors to concepts I could find authors for

* rename `hint.md` to `hints.md` so the linter (and everything else) will find the file
ViralBShah pushed a commit that referenced this issue Nov 9, 2023
@DilumAluthgeBot @DilumAluthge
🤖 [master] Bump the SparseArrays stdlib from 3582898 to 37fc321 (#52089)
c95cb95 
Stdlib: SparseArrays
URL: https://github.com/JuliaSparse/SparseArrays.jl.git
Stdlib branch: main
Julia branch: master
Old commit: 3582898
New commit: 37fc321
Julia version: 1.11.0-DEV
SparseArrays version: 1.11.0
Bump invoked by: @ViralBShah
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaSparse/SparseArrays.jl@3582898...37fc321

```
$ git log --oneline 3582898..37fc321
37fc321 test: relax allocated tests (#468)
bd2bda8 replace ind2sub/sub2ind by CartesianIndices/LinearIndices (#451)
7897f1f test: somewhat more permissive test_throws message (#466)
911cf6a `reverse` for sparse vector/matrix (#450)
713a260 Define algebraic operators for SparseMatrixCSCView (#458)
f455a8e Add messages to DimensionMismatch errors (#461)
81fc6f3 Aggressive constprop in sparse * dense (#460)
0b36fdd fix h/vcat invoke dispatch arguments (#464)
6b23902 Add Finch to list of External Julia Sparse Array Libraries (#462)
```

Co-authored-by: Dilum Aluthge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanKarpinski StefanKarpinski

Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StefanKarpinski @JeffBezanson