-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect inference in MTK #43082
Labels
bug
Indicates an unexpected problem or unintended behavior
compiler:inference
Type inference
types and dispatch
Types, subtyping and method dispatch
Comments
Keno
added
bug
Indicates an unexpected problem or unintended behavior
compiler:inference
Type inference
types and dispatch
Types, subtyping and method dispatch
labels
Nov 15, 2021
|
Non-MTK reduction:
|
Also happens on 1.7. Haven't seen this in the wild yet with regular MTK usage, but that of course depends on inference to figure out the argument to this constructor. |
1.0: works |
Slightly smaller:
|
Keno
added a commit
to Keno/ModelingToolkit.jl
that referenced
this issue
Nov 16, 2021
Avoids a base julia type intersection issue: JuliaLang/julia#43082. The overparameterization is not particularly required - Julia is fast at union splitting and this access is not particularly hot anyway.
Keno
added a commit
to Keno/ModelingToolkit.jl
that referenced
this issue
Nov 16, 2021
Avoids a base julia type intersection issue: JuliaLang/julia#43082. The overparameterization is not particularly required - Julia is fast at union splitting and this access is not particularly hot anyway.
YingboMa
pushed a commit
to SciML/ModelingToolkit.jl
that referenced
this issue
Nov 17, 2021
* Don't overparametrize BipartiteGraph Avoids a base julia type intersection issue: JuliaLang/julia#43082. The overparameterization is not particularly required - Julia is fast at union splitting and this access is not particularly hot anyway.
N5N3
added a commit
to N5N3/julia
that referenced
this issue
Aug 15, 2022
N5N3
added a commit
to N5N3/julia
that referenced
this issue
Aug 15, 2022
N5N3
added a commit
that referenced
this issue
Aug 18, 2022
… tries a new Union decision (#46350) * `intersect_all` should always `restore_env`. let `merge_env` track valid `env` change. * Add test. Co-authored-by: Jeff Bezanson <[email protected]>
KristofferC
pushed a commit
that referenced
this issue
Aug 26, 2022
… tries a new Union decision (#46350) * `intersect_all` should always `restore_env`. let `merge_env` track valid `env` change. * Add test. Co-authored-by: Jeff Bezanson <[email protected]> (cherry picked from commit 9aabb4c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Indicates an unexpected problem or unintended behavior
compiler:inference
Type inference
types and dispatch
Types, subtyping and method dispatch
Using Julia and MTK master:
The inference of the constructor is incorrect. The function returns, causing the subsequent crash. I suspect an intersection issue of some sort as usual, but I will investigate further.
The text was updated successfully, but these errors were encountered: