Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unreachable reached with missing, === and | #40612

Closed
rfourquet opened this issue Apr 26, 2021 · 1 comment · Fixed by #41046
Closed

unreachable reached with missing, === and | #40612

rfourquet opened this issue Apr 26, 2021 · 1 comment · Fixed by #41046
Assignees
@vtjnash
Labels
bug Indicates an unexpected problem or unintended behavior regression Regression in behavior compared to a previous version
Milestone
1.7

Comments

@rfourquet
Copy link
Member

This fails on 1.6 and one week old master:

julia> f(a, b) = a|b === a|b
f (generic function with 1 method)

julia> f(true, missing)
Unreachable reached at 0x7f2bc3c84d49

signal (4): Illegal instruction
in expression starting at REPL[2]:1
f at ./REPL[1]:1
unknown function (ip: 0x7f2bc3c84d65)
[...]
@rfourquet rfourquet added the bug Indicates an unexpected problem or unintended behavior label Apr 26, 2021
@simeonschaub simeonschaub mentioned this issue Apr 26, 2021
Closed
@vtjnash vtjnash self-assigned this Apr 26, 2021
@vtjnash
Copy link
Member

vtjnash commented Apr 26, 2021

Looks like there is several problems with emit_bitsunion_compare

@martinholters martinholters added the regression Regression in behavior compared to a previous version label Apr 26, 2021
@vtjnash vtjnash mentioned this issue May 19, 2021
Closed
@JeffBezanson JeffBezanson added this to the 1.7 milestone May 27, 2021
vtjnash added a commit that referenced this issue Jun 1, 2021
@vtjnash
codegen: fixing union isbits comparison UB
f713dad 
Fixes #40612
Fixes #40834
@vtjnash vtjnash mentioned this issue Jun 1, 2021
Merged
vtjnash added a commit that referenced this issue Jun 2, 2021
@vtjnash
codegen: fixing union isbits comparison UB (#41046)
33fa18b 
Fixes #40612
Fixes #40834
KristofferC pushed a commit that referenced this issue Jun 4, 2021
@vtjnash @KristofferC
codegen: fixing union isbits comparison UB (#41046)
8d5ed1e 
Fixes #40612
Fixes #40834

(cherry picked from commit 33fa18b)
shirodkara pushed a commit to shirodkara/julia that referenced this issue Jun 9, 2021
@vtjnash
codegen: fixing union isbits comparison UB (JuliaLang#41046)
f14e4f4 
Fixes JuliaLang#40612
Fixes JuliaLang#40834
johanmon pushed a commit to johanmon/julia that referenced this issue Jul 5, 2021
@vtjnash @johanmon
codegen: fixing union isbits comparison UB (JuliaLang#41046)
2a070c7 
Fixes JuliaLang#40612
Fixes JuliaLang#40834
staticfloat pushed a commit that referenced this issue Dec 23, 2022
@vtjnash @staticfloat
codegen: fixing union isbits comparison UB (#41046)
a347511 
Fixes #40612
Fixes #40834

(cherry picked from commit 33fa18b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vtjnash vtjnash

Labels
bug Indicates an unexpected problem or unintended behavior regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
1.7
Development

Successfully merging a pull request may close this issue.

codegen: fixing union isbits comparison UB JuliaLang/julia
4 participants
@vtjnash @JeffBezanson @rfourquet @martinholters