Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BitArray is documented to be a DenseArray #30337

Closed
eschnett opened this issue Dec 10, 2018 · 2 comments
Closed

BitArray is documented to be a DenseArray #30337

eschnett opened this issue Dec 10, 2018 · 2 comments
Labels
docs This change adds or pertains to documentation

Comments

@eschnett
Copy link
Contributor

The documentation of BitArray claims that it is a subtype of DenseArray (file bitarray.jl) in its documentation, but the type declaration makes it only a subtype of AbstractArray. I don't know which is correct (probably the code...), but the inconsistency should be resolved.
@mbauman
Copy link
Member

mbauman commented Dec 10, 2018

Ah, whoops, that's a documentation bug. They were indeed previously DenseArrays, but that was a problem: #25858. My mistake for missing the doc portion of the change.

@mbauman mbauman added the docs This change adds or pertains to documentation label Dec 10, 2018
@mbauman mbauman changed the title BitArray is not subtype of DenseArray BitArray is documented to be a DenseArray Dec 10, 2018
@fredrikekre fredrikekre added the good first issue Indicates a good issue for first-time contributors to Julia label Dec 10, 2018
mbauman added a commit that referenced this issue Dec 10, 2018
@mbauman
Expand and fix documentation of BitArray
3e6b8be 
Fixes #30337... and while I was there I added a bit more information about what BitArrays do and when you might run into them.
@mbauman mbauman mentioned this issue Dec 10, 2018
Merged
@mbauman
Copy link
Member

mbauman commented Dec 10, 2018 •
edited
Loading

Sorry for stealing the #good-first-issue… I figured I'd clean up my own mess.

@mbauman mbauman removed the good first issue Indicates a good issue for first-time contributors to Julia label Dec 10, 2018
fredrikekre pushed a commit that referenced this issue Dec 11, 2018
@mbauman @fredrikekre
Expand and fix documentation of BitArray (#30340)
0d62000 
Fixes #30337... and while I was there I added a bit more information about what BitArrays do and when you might run into them.
KristofferC pushed a commit that referenced this issue Dec 12, 2018
@mbauman @KristofferC
Expand and fix documentation of BitArray (#30340)
ca1b40e 
Fixes #30337... and while I was there I added a bit more information about what BitArrays do and when you might run into them.

(cherry picked from commit 0d62000)
KristofferC pushed a commit that referenced this issue Dec 30, 2018
@mbauman @KristofferC
Expand and fix documentation of BitArray (#30340)
2cadff3 
Fixes #30337... and while I was there I added a bit more information about what BitArrays do and when you might run into them.

(cherry picked from commit 0d62000)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbauman @eschnett @fredrikekre