Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mapslices' dim argument should be a keyword #27774

Closed
nalimilan opened this issue Jun 25, 2018 · 1 comment · Fixed by #27828
Closed

mapslices' dim argument should be a keyword #27774

nalimilan opened this issue Jun 25, 2018 · 1 comment · Fixed by #27828
Labels
deprecation This change introduces or involves a deprecation
Milestone
0.7

Comments

@nalimilan
Copy link
Member

mapslices is currently inconsistent with all reduction functions (e.g. mapreduce) in that its dim argument has remained positional while it has been made a keyword argument everywhere else.
@nalimilan nalimilan added the deprecation This change introduces or involves a deprecation label Jun 25, 2018
@StefanKarpinski StefanKarpinski added the triage This should be discussed on a triage call label Jun 25, 2018
@JeffBezanson
Copy link
Member

I'll make a PR for this.

JeffBezanson added a commit that referenced this issue Jun 27, 2018
@JeffBezanson
make dims argument to mapslices a keyword arg
d184a46 
fixes #27774
@JeffBezanson JeffBezanson mentioned this issue Jun 27, 2018
Merged
@StefanKarpinski StefanKarpinski removed the triage This should be discussed on a triage call label Jun 28, 2018
@StefanKarpinski StefanKarpinski added this to the 0.7 milestone Jun 28, 2018
mbauman pushed a commit that referenced this issue Jun 28, 2018
@JeffBezanson @mbauman
make dims argument to mapslices a keyword arg (#27828)
440a1a5 
fixes #27774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecation This change introduces or involves a deprecation
Projects
None yet
Milestone
0.7
Development

Successfully merging a pull request may close this issue.

make dims argument to mapslices a keyword arg JuliaLang/julia
3 participants
@StefanKarpinski @JeffBezanson @nalimilan