Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect element type from specialized sparse unary broadcast methods #18974

Closed
Sacha0 opened this issue Oct 16, 2016 · 0 comments · Fixed by #19065
Closed

Incorrect element type from specialized sparse unary broadcast methods #18974

Sacha0 opened this issue Oct 16, 2016 · 0 comments · Fixed by #19065
Labels
sparse Sparse arrays

Comments

@Sacha0
Copy link
Member

Sacha0 commented Oct 16, 2016

The broadcast methods specialized for unary operations over SparseMatrixCSCs assume that the input matrix's element type is appropriate for the returned matrix (e.g. here). This assumption causes, for example,

julia> VERSION
v"0.6.0-dev.979"

julia> sin.(speye(Int, 4))
ERROR: InexactError()
 in convert(::Type{Int64}, ::Float64) at ./float.jl:637
 in _broadcast_unary_nz2z_z2z_T(::Base.#sin, ::SparseMatrixCSC{Int64,Int64}, ::Type{Int64}) at ./sparse/sparsematrix.jl:1425
 in broadcast(::Base.#sin, ::SparseMatrixCSC{Int64,Int64}) at ./sparse/sparsematrix.jl:1403

Best!
@Sacha0 Sacha0 added the sparse Sparse arrays label Oct 16, 2016
This was referenced Oct 19, 2016
Closed
Merged
Sacha0 added a commit to Sacha0/julia that referenced this issue Nov 26, 2016
@Sacha0
Add test for issue JuliaLang#18974 (incorrect eltype from broadcast o…
74c0bb7 
…ver a sparse matrix) from closed PR JuliaLang#18975 that was missed in PR JuliaLang#19065.
@Sacha0 Sacha0 mentioned this issue Nov 26, 2016
Merged
Sacha0 added a commit to Sacha0/julia that referenced this issue Nov 27, 2016
@Sacha0
Add test for issue JuliaLang#18974 (incorrect eltype from broadcast o…
4cf8f62 
…ver a sparse matrix) from closed PR JuliaLang#18975 that was missed in PR JuliaLang#19065.
Sacha0 added a commit to Sacha0/julia that referenced this issue Dec 1, 2016
@Sacha0
Add test for issue JuliaLang#18974 (incorrect eltype from broadcast o…
ca87f75 
…ver a sparse matrix) from closed PR JuliaLang#18975 that was missed in PR JuliaLang#19065.
Sacha0 added a commit that referenced this issue Dec 2, 2016
@Sacha0
Merge pull request #19425 from Sacha0/testspbctype
c80d523 
Add test for issue #18974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sparse Sparse arrays
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify nz2nz_z2z-class sparse unary broadcast (and fix #18974) Sacha0/julia
1 participant
@Sacha0